attributes: force instrumented function to be FnOnce
#2897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2024
mladedav
force-pushed
the
dm/instrument-fn-mut-master
branch
from
92b7168 to
442f558
Compare
|
Seems similar to #2847 ? |
|
You're right, I'll close it in favor of your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2857
Motivation
Functions which are
FnorFnMutfail to compile when they are instrumented with#[instrument(ret)]Solution
I've added a non-copy zst (
[&mut (), 0]) to the generated code that is moved inside the function so that it is forced to be no more thanFnOnce.