Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Thumbnail preview #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Thumbnail preview #95

wants to merge 2 commits into from

Conversation

relikd
Copy link

@relikd relikd commented Jan 16, 2020

Took some time to figure that out but quite an easy fix for issue #88.

@frankrolf
Copy link

I would be thankful and grateful if this PR could be merged.
(If this is not possible, I’d appreciate instructions for building the plugin myself.)

Thanks!

@relikd
Copy link
Author

relikd commented Feb 12, 2020

I was writing this tutorial when I realized that the rendering didn't actually took place as intended. It was removed with merge #91 and replaced with a plain text output. (don't ask why I was developing this fix on an old branch, I don't know)
Now the thumbnail preview should work properly!

Anyway, here is the paste-it-in-Terminal-and-everything-is-done-automatically script:

cd ~/Downloads
git clone https://github.com/relikd/qlmarkdown qlmarkdown-relikd
cd qlmarkdown-relikd
rm -rf discount/
git clone git://github.com/Orc/discount.git discount
cd discount
git checkout v2.2.6
cd ..
xcodebuild -configuration Release
cp -rf build/Release/QLMarkdown.qlgenerator ~/Library/QuickLook

But maybe @toland can now merge it? :)

@relikd
Copy link
Author

relikd commented Feb 12, 2020

I also noticed that tables are not rendered?
screen

@frankrolf
Copy link

Tables are (afaik) not part of the official .md spec – they are an addition which only works on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants