Add Android Place Photos Support #154

thomasw · 2018-07-06T22:24:59Z

As discussed in #149 (comment) (with some slight modifications), this adds the following Google Place Photo API wrappers for android:

> RNGooglePlaces.getPlacePhotosMetadata(placeID)
[{
  placeId: '...',
  photoId: '...',
  attributions: '...',
  maxWidth: ...,
  maxHeight: ....
},
...
]

// Same as above, but it saves all the images to disk and returns a uri for each.
> RNGooglePlaces.getPlacePhotos(placeID)
[{
  placeId: '...',
  photoId: '...',
  attributions: '...'
  maxWidth: ...,
  maxHeight: ...,
  uri: 'file://...'
},
...
]

> RNGooglePlaces.getPlacePhoto(placePhotoMeta)
'file://...'

> RNGooglePlaces.getScaledPlacePhoto(placePhotoMeta, height, width)
'file://...'

Files should always end with new lines to avoid introducing extraneous diffs.

This introduces preliminary support for 1. retrieving photo metadata for a place and 2. persisting the associated photos to disk where they can be accessed via react-native using an `<Image>` tag. Example usage via JS: ```javascript const placePhotos = await RNGooglePlaces.getPlacePhotos(placeId) const firstPhotoUri = await RNGooglePlaces.getPlacePhoto(placePhotos[0]) console.info(firstPhotoUri) ```

Place photos shouldn't be persisted indefinitely. We write them to a cache directory so that the OS knows that it can clean these files up if necessary. This also removes specifying context.MODE_PRIVATE when creating the FileOutputStream, which doesn't seem necessary.

This makes the return type consistent with the method's current naming.

File.toURI returns a URI, not a Uri.

ResultCallbacks (vs ResultCallback) allows us to factor out status checks because we can define specific handlers for success/failure cases. ResultTransform allows us to neatly chain API calls without needing to pass promise references down deeply into multiple methods.

I'd believed that this wasn't required when using .then(...).andFinally(...) pattern, but according to the console warnings this was resulting in, it is indeed required.

devlinb · 2018-09-07T23:36:44Z

Any chance of this getting merged? This is great functionality that I'd love to see added!

thomasw added 12 commits June 29, 2018 15:11

Remove unused react import

d3192a8

index.js: Add missing EOF newline

258194c

Files should always end with new lines to avoid introducing extraneous diffs.

getURIForBitmap: return a URI instead of String

7f6a8ef

This makes the return type consistent with the method's current naming.

getUriForBitmap: correct invalid return type

d0c5aa1

File.toURI returns a URI, not a Uri.

Add getScaledPhoto support for Android

a255a49

Rename getPlacePhotos to getPlacePhotoMetadata

6724345

getPlacePhotosMetadata: simplify 0 photos case

a87467c

getScaledPhoto: Call .release() on buffer

a6c6954

I'd believed that this wasn't required when using .then(...).andFinally(...) pattern, but according to the console warnings this was resulting in, it is indeed required.

Add getPlacePhotos support

669cf38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Android Place Photos Support #154

Add Android Place Photos Support #154

thomasw commented Jul 6, 2018

devlinb commented Sep 7, 2018

Add Android Place Photos Support #154

Are you sure you want to change the base?

Add Android Place Photos Support #154

Conversation

thomasw commented Jul 6, 2018

devlinb commented Sep 7, 2018