Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rewrite renderer parser #58

Merged
merged 5 commits into from
May 21, 2020
Merged

feat: rewrite renderer parser #58

merged 5 commits into from
May 21, 2020

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented May 10, 2020

No description provided.

@obfusk obfusk force-pushed the improve-parsing branch from 5e5f567 to 85600f2 Compare May 12, 2020 16:59
@enzoferey
Copy link
Collaborator

Sorry for the delay @obfusk, I will check this out tomorrow first thing. It looks pretty good 👍

enzoferey
enzoferey reviewed May 19, 2020
View reviewed changes
src/aliasRegex.js Outdated Show resolved Hide resolved
@enzoferey
Copy link
Collaborator

Thanks @obfusk for the work 🔥 Would you mind commenting a bit more the replaceAliases function ? Things like why aliases[(ascii + full).slice(1, -1)], match.index > pos, text.slice(pos, match.index), match[0], full, etc. A mix of comments and better variable namings 👌

I think being over verbose on these topics is key for future people being able to contribute easily. Previous algorithm was pretty bad compared to this one, but it was easy to understand I would say.

@obfusk
Copy link
Contributor Author

obfusk commented May 21, 2020

@enzoferey I added a commit with some comments & renamed variables.

enzoferey
enzoferey approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@enzoferey enzoferey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, it's great 💯

@enzoferey enzoferey changed the title rewrite parser feat: rewrite renderer parser May 21, 2020
@enzoferey enzoferey merged commit 09110cf into tommoor:master May 21, 2020
@enzoferey
Copy link
Collaborator

@tommoor feel free to do a release if you like for this one and #51 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enzoferey enzoferey enzoferey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obfusk @enzoferey