Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Public preview #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Public preview #6

wants to merge 4 commits into from

Conversation

tomneedham
Copy link
Owner

@tomneedham tomneedham commented Aug 15, 2018

TODO:

  • Pass in URL to public.js somehow
  • Unify drawio url location (in application.php, public.js and PageController.php)
  • Only load public preview for .drawio files

@tomneedham tomneedham self-assigned this Aug 15, 2018
action: "load",
xml: data
}), "*");
});
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add error handling

js/public.js Outdated
$(document).ready(function(){
if ($('#isPublic').val()) {
// TODO this needs to be imported
var src = 'https://www.draw.io?embed=1&chrome=0&spin=1&stealth=1&proto=json';
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pass in this url from somewhere??


$manager = \OC::$server->getContentSecurityPolicyManager();
$policy = new ContentSecurityPolicy();
$policy->addAllowedFrameDomain('https://www.draw.io');
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Unify this url config

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove csp from page controller as it is handled here now

@tomneedham
Copy link
Owner Author

screen shot 2018-08-15 at 13 21 07

@tomneedham tomneedham changed the title [WIP] Public preview Public preview Aug 15, 2018
@tomneedham
Copy link
Owner Author

drawio.tar.gz
Please test

@cdamken
Copy link

cdamken commented Aug 28, 2018

Tested ;)
#8

@tomneedham
Copy link
Owner Author

Does this PR cause #8 or is that something different?

@digitall-it
Copy link

Greetings, came to this issue because I tried to share a diagram as a public link without password, and it seems to not work yet. I'm using v0.9.4 under NextCloud v17. Congratulations for all the hard work.

@tomneedham
Copy link
Owner Author

Greetings, came to this issue because I tried to share a diagram as a public link without password, and it seems to not work yet. I'm using v0.9.4 under NextCloud v17. Congratulations for all the hard work.

@digitall-it Well - this app is made for ownCloud :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants