Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds options.type override #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

alycda
Copy link

@alycda alycda commented Sep 11, 2019

I'm using Semantic UI Less, and because some of the files processed by less do not contain .less as the extension, the plugin doesn't work for me as expected.

I must import the variables here: https://glitch.com/edit/equinox-motion?path=ui/styles/semantic.less:15:17 so that your loader will know what type of variables to create.

But due to the load order, I need to import the variables here: https://glitch.com/edit/#!/equinox-motion?path=ui/styles/site/globals/site.variables:1 so that they actually override the defaults.

I expect that I will be able to move the require statements to the .variables file and update webpack.config to

{
  loader: "js-to-styles-var-loader",
  options: { type: 'less' }, 
}

Copy link
Owner

@tompascall tompascall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi! it seems ok,except that I suggest not commiting the .vscode file

@@ -0,0 +1,18 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this file

@constgen
Copy link
Contributor

Please look how I resolved the similar issue in Vue components #10. We can just consider such cases internally without requiring of external configuration

@tompascall
Copy link
Owner

tompascall commented Aug 17, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants