Skip to content

Commit

Permalink
POSIX: MSVC really does have signbit()
Browse files Browse the repository at this point in the history
But it appears that the fallback for Perl_signbit() in numeric.c
is broken when we've found a definition for Perl_fp_class_nzero().

When Perl_fp_class_nzero is defined, the fallback Perl_signbit()
simply returns that value, but Perl_fp_class_nzero() only returns
true when the number is negative zero, not for any negative number.

But C99 requires signbit(), so I don't think it's worth spending
any more time looking into this.  We might want to eliminate
Perl_signbit() from numeric.c, or try to fix it.
  • Loading branch information
tonycoz committed Nov 6, 2023
1 parent c0ae046 commit 2a6624f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion win32/config.vc
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ d_siginfo_si_pid='undef'
d_siginfo_si_status='undef'
d_siginfo_si_uid='undef'
d_siginfo_si_value='undef'
d_signbit='undef'
d_signbit='define'
d_sigprocmask='undef'
d_sigsetjmp='undef'
d_sin6_scope_id='define'
Expand Down

0 comments on commit 2a6624f

Please sign in to comment.