Circle information view and scheduling #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will show information about the circle and whether or not it is available to join.
Frontend: - Added all the types to support repeating/scheduled circles - Update circle states to include scheduled - Updated the create circle UI with lots of options for scheduled circles - Updated the circle creation interface to take in and handle the params for scheduled circles - Updated the circle model for scheduled circles - Updated logic on circle end to handle "scheduled" as an ended state Backend: - Fixed one of the indexes which was using the wrong field - Updated `SnapCircleData` to be easier to compare to frontend model - Updated the scheduler to initialize sessions when putting a scheduled circle into the waiting state - Fixed some logic and handling of repeat options when creating a circle
…eduled-circles Scheduled circle creation options
Shows the repeating and upcoming session information
|
Visit the preview URL for this PR (updated for commit 6204cce): https://totem-dev-184f1--pr375-feature-circle-infor-bh6ofz7l.web.app (expires Thu, 03 Nov 2022 00:09:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 342fab022be633deeda6c5e16fade4a8747834ae |
for some reason my editor formatted/sorted these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for:
#319 #355 #307 #242
This ticket combines support for scheduling and viewing the circle information before joining. It also adds support to the create circle flow for putting in scheduled circles and cleans up use of old scheduled circle references.