Remove odd metadata reassign #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to reassign metalsmith metadata, because of metalsmith return its internal metadata object. So if something changed in this metadata object its changed for all next plugin.
But when we reassign metalsmith metadata with
metadata(<new metadata>)function this<new metadata>clones with deep copying. And this deep copying breaks the consistency of previously created referencing (for example bymetalsmith-collectionsplugin) from some metadata property to files objects. And if next plugins change something in files, this change will not reflect in metadata, because of metadata property reference to copied files objects.