Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade http and sync_wrapper dependencies #788

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

elichai
Copy link
Contributor

@elichai elichai commented Aug 18, 2024

Upgrade these dependencies to allow downstream users to reduce duplicate dependencies
(specifically this makes axum CI fail for duplicate dependencies when upgrading to tower 0.5: https://github.com/tokio-rs/axum/actions/runs/10440315723/job/28910071844?pr=2880 )

@tottoto
Copy link
Contributor

tottoto commented Aug 24, 2024

I think this is not breaking change as http crate is dev-dependency, and sync_wrapper's type is not exposed and the behaviour is not changed from 0.1.

@elichai
Copy link
Contributor Author

elichai commented Sep 8, 2024

@jplatte Any chance we can get this in 5.1?

@jplatte
Copy link
Contributor

jplatte commented Sep 8, 2024

Sorry, I maintain tower-http but not tower. I don't think I even have the right to merge things here.

Copy link
Contributor

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can check though... Nope, that checkmark is not green.

@elichai
Copy link
Contributor Author

elichai commented Sep 20, 2024

@seanmonstar ping maybe?

@kanpov
Copy link

kanpov commented Nov 19, 2024

@seanmonstar any update on this? Would be good to eliminate sync_wrapper duplication

@seanmonstar seanmonstar merged commit 6283f3a into tower-rs:master Nov 19, 2024
14 checks passed
@elichai elichai deleted the upgrade-deps branch November 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants