v5 #17
Closed
v5 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- due to schema changes between versions, we need to completely nuke the DB between these tests - this is definitely not the best way to do it but I'll fix properly next week
refs https://github.com/TryGhost/Arch/issues/25 - The built in index (soon -> "latest") collection does not require any filtering so that it could contain an index of all posts in the system. All other automatic collections should have a filter defined.
- we only need this on the metadata step because it trickles down to the other workflows that depend on it
- if a branch is force-pushed, the existing value is incorrect and we get errors from Lerna - this switches to finding the common commit between this branch and the head as reported by GitHub
refs https://ghost.slack.com/archives/C02G9E68C/p1688983916615989?thread_ts=1687341349.559679&cid=C02G9E68C - these cause issues with our PR workflow because we can't push tags in a PR and the commit is rebased onto `main` so the hash changes - this disables tags for now
- unfortunately GitHub makes this incredibly hard and this commit doesn't even provide a full solution, but it should allow us to fetch the latest commit for PRs and pushes to a branch, but not force pushes
refs TryGhost/Product#3508 - added a feature flag for Header Cards that's being upgraded. --- <!-- Leave the line below if you'd like GitHub Copilot to generate a summary from your commit --> <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 10ac1e4</samp> This pull request adds a new feature flag `headerUpgrade` to the server and the admin settings, which allows the user to opt-in to a new header design. The feature flag is only available if the labs toggle is enabled.
- we shouldn't cache the build assets against the yarn.lock hash because the files could change independent of that file - this bring the build caching more inline with https://github.com/getsentry/sentry-javascript/blob/develop/.github/workflows/build.yml, which is a big inspiration for this file
- we probably just want to run my logic to get the base commit for all pushes because otherwise the `base.sha` will be null for new branches
- echoing the data should avoid issues with piping in data through a file redirection
no refs -alpha flag for collections card for pages
refs. TryGhost/Product#3580 - A couple of static components were needed as a starting point for Tiers in AdminX settings.
fixes TryGhost/DevOps#42 - several of our dependencies require this so making the minor bump to increase the version helps keep them updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
差分確認用