Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Configure CodeQL explicitly #798

Merged
merged 2 commits into from
Nov 8, 2024
Merged

🔧 Configure CodeQL explicitly #798

merged 2 commits into from
Nov 8, 2024

Conversation

H1rono
Copy link
Member

@H1rono H1rono commented Sep 1, 2024

CodeQLのCIが落ちるようになったので

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.22%. Comparing base (07b26df) to head (5cb82e4).
Report is 23 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #798      +/-   ##
==========================================
- Coverage   25.70%   25.22%   -0.48%     
==========================================
  Files         148      148              
  Lines       26892    30578    +3686     
==========================================
+ Hits         6912     7714     +802     
- Misses      19104    21988    +2884     
  Partials      876      876              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono H1rono force-pushed the configure-codeql branch 5 times, most recently from c0a3de4 to ca5d556 Compare September 1, 2024 10:13
@H1rono
Copy link
Member Author

H1rono commented Sep 1, 2024

CodeQLがどうもGo1.23をサポートしていないのが良くなさそう
https://github.com/github/codeql/blob/642ec38589afa7549e6ebb2ca0fb84ed2c6867da/go/extractor/autobuilder/build-environment.go#L14-L15
しばらく寝かせます

@H1rono
Copy link
Member Author

H1rono commented Nov 8, 2024

おk

@H1rono H1rono merged commit 60dcf5f into v2 Nov 8, 2024
5 of 6 checks passed
@H1rono H1rono deleted the configure-codeql branch November 8, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant