Correction webhook eventhandler

[Hueter57]

#769

TransactionをTransactionNewCreateとTransactionCorrectionに分離

webhook.goも構造体を分け、POSTとPUTで処理を分けた

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 115 lines in your changes missing coverage. Please review.

Project coverage is 25.22%. Comparing base (7a76319) to head (a040a41).
Report is 22 commits behind head on v2.

Files with missing lines	Patch %	Lines
service/webhook.go	0.00%	107 Missing ⚠️
router/router.go	0.00%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               v2     #815      +/-   ##
==========================================
- Coverage   25.25%   25.22%   -0.03%     
==========================================
  Files         147      147              
  Lines       30735    30752      +17     
==========================================
- Hits         7761     7757       -4     
- Misses      22088    22109      +21     
  Partials      886      886              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[H1rono]

とりあえず

[H1rono]

🙏

[H1rono]

とりあえずこれだけ

[H1rono]

ここlog残したいな(後でissueにする)

[H1rono]

よく分けられてます

/api/requests以下と/api/transactions以下でmiddleware.BodyDumpに渡す関数を分けたら嬉しそうだなと思ったんですが、お願いできますか？

/requests以下はWebhookEventHandlerを経由してWebhookRequestsEventHandlerを呼び出すのではなくWebhookRequestsEventHandlerを直接渡して、

Jomon/router/router.go

Lines 49 to 67 in 0f91889

	apiRequests := api.Group("/requests", h.CheckLoginMiddleware)
	{
	apiRequests.GET("", h.GetRequests)
	apiRequests.POST("", h.PostRequest, middleware.BodyDump(service.WebhookEventHandler))
	apiRequestIDs := apiRequests.Group("/:requestID", retrieveRequestCreator)
	{
	apiRequestIDs.GET("", h.GetRequest)
	apiRequestIDs.PUT(
	"",
	h.PutRequest,
	middleware.BodyDump(service.WebhookEventHandler),
	h.CheckRequestCreatorMiddleware)
	apiRequestIDs.POST(
	"/comments",
	h.PostComment,
	middleware.BodyDump(service.WebhookEventHandler))
	apiRequestIDs.PUT("/status", h.PutStatus, h.CheckAdminOrRequestCreatorMiddleware)
	}
	}

/api/transactions以下も同様にWebhookTransactionsEventHandlerを直接渡す形を想定してます

Jomon/router/router.go

Lines 69 to 83 in 0f91889

	apiTransactions := api.Group("/transactions", h.CheckLoginMiddleware)
	{
	apiTransactions.GET("", h.GetTransactions)
	apiTransactions.POST(
	"",
	h.PostTransaction,
	middleware.BodyDump(service.WebhookEventHandler),
	h.CheckAdminMiddleware)
	apiTransactions.GET("/:transactionID", h.GetTransaction)
	apiTransactions.PUT(
	"/:transactionID",
	h.PutTransaction,
	middleware.BodyDump(service.WebhookEventHandler),
	h.CheckAdminMiddleware)
	}

[H1rono]

LGTM 👍