swagger.yamlの改修 #1140
Merged
swagger.yamlの改修 #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
- Coverage 60.41% 60.07% -0.34%
==========================================
Files 20 20
Lines 2981 3001 +20
==========================================
+ Hits 1801 1803 +2
- Misses 1020 1036 +16
- Partials 160 162 +2 ☔ View full report in Codecov by Sentry. |
responseを整理
APIの整理
cp-20
requested changes
Dec 10, 2023
cp-20
reviewed
Dec 10, 2023
cp-20
reviewed
Dec 10, 2023
cp-20
reviewed
Dec 10, 2023
cp-20
reviewed
Dec 10, 2023
requiredの修正 descriptionの修正 QuestionnaireAllRespondedの削除 QuestionTypeの整理
git pull --rebase で発生したエラーを修正
QuestionnaireRespondentsのミスの修正
… into feature/yaml-v2
reviewに対応した細かな修正
/questionnaires/{questionnaireID}/myRemindStatus の作成(プロトタイプ)
QuestionnaireMyRemindStatusのdescriptionを修正
cp-20
reviewed
Dec 12, 2023
…ed_atをResponseに移動)
formatterが効いただけの虚無コミット
cp-20
reviewed
Dec 12, 2023
cp-20
reviewed
Dec 12, 2023
cp-20
reviewed
Dec 12, 2023
cp-20
reviewed
Dec 12, 2023
cp-20
reviewed
Dec 12, 2023
cp-20
reviewed
Dec 12, 2023
cp-20
reviewed
Dec 12, 2023
QuestionnaireIsRemindEnabledをobjectに変更 QuestionnaireIsRemindEnabledの命名を改善
propertiesをsnake_caseに統一 requiredを修正
answer_counts_per_indexにproperty名を変更
前コミットでのrequired修正ミスを修正
ResultSettingsAnswerCountPerに関する細かな修正など
Co-authored-by: cp20 <[email protected]>
maxLength, minValue, maxLengthをrequiredから外し、snake_caseに変更
cp-20
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
匿名回答と複数回答不可に対する仕様は議論が必要かもです
schemaのgroupとuserは必要性の確認とAPI設計の考察できてないです