Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement GetQuestionnaireResult, GetMyResponses, GetResponse and DeleteResponse #1265

Merged
merged 10 commits into from
Sep 2, 2024

Conversation

Eraxyso
Copy link

@Eraxyso Eraxyso commented Aug 28, 2024

Closes #1244, #1245, #1246 and #1247

@Eraxyso Eraxyso requested a review from kaitoyama August 28, 2024 10:39
Copy link
Contributor

@kaitoyama kaitoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
何点かコメントをしたので、読んだらマージしちゃってください(具体の対応は今は不要です)

}

for _, response := range responses {
tmp := struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI 現状openapi側の書き方があんまりよくないせいでopenapi由来のtype.go使えてないので後で修正します

model/respondents_impl.go Show resolved Hide resolved
model/targets_impl.go Show resolved Hide resolved
@Eraxyso Eraxyso merged commit 0421e8e into fix/openapi Sep 2, 2024
4 of 7 checks passed
@Eraxyso Eraxyso deleted the fix/openapi-1 branch September 2, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants