Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リマインダーの実装(openapi) #1279

Merged
merged 8 commits into from
Dec 1, 2024
Merged

Conversation

kavos113
Copy link

@kavos113 kavos113 commented Nov 5, 2024

#1218 をopenapi向けに移植

@kavos113 kavos113 requested a review from kaitoyama November 5, 2024 06:06
@kavos113 kavos113 changed the title impl: add is_canceled to targets リマインダーの実装(openapi) Nov 5, 2024
@kaitoyama
Copy link
Contributor

@kavos113
Copy link
Author

kavos113 commented Nov 5, 2024

実装しました

@kaitoyama
Copy link
Contributor

実装自体は問題なさそうです!
confilict解消だけお願いします:pray:

Copy link
Contributor

@kaitoyama kaitoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@kaitoyama kaitoyama merged commit 98d8c16 into fix/openapi Dec 1, 2024
4 of 7 checks passed
@kaitoyama kaitoyama deleted the fix/openapi-reminder branch December 1, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants