Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioButtonとRadioCardの実装 #57

Merged
merged 20 commits into from
Dec 18, 2024
Merged

RadioButtonとRadioCardの実装 #57

merged 20 commits into from
Dec 18, 2024

Conversation

Nattuki
Copy link
Contributor

@Nattuki Nattuki commented Jul 14, 2024

close #54
close #55

@Nattuki Nattuki self-assigned this Jul 14, 2024
@Nattuki Nattuki requested a review from cp-20 July 14, 2024 17:29
Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見た目については文句なしです! 流石です!

ただコードの書き方的なところについてちょっとだけコメントしたのでサッと確認して修正してもらえると嬉しいです!

index.html Outdated Show resolved Hide resolved
src/shared/components/RadioCard.vue Outdated Show resolved Hide resolved
/>
<label
:class="$style.container"
:style="`width: ${props.width}`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<style>タグ内で v-bindを使った方がシンプルに書けると思います:eyes:
https://azukiazusa.dev/blog/vue3-2-style-javascript/

src/shared/components/RadioCard.vue Outdated Show resolved Hide resolved
src/shared/components/RadioButton.vue Outdated Show resolved Hide resolved
src/shared/components/RadioCard.vue Outdated Show resolved Hide resolved
@Nattuki Nattuki requested a review from cp-20 July 21, 2024 18:05
@cp-20 cp-20 merged commit 99974e8 into main Dec 18, 2024
2 checks passed
@cp-20 cp-20 deleted the Natsuki/RadioCard branch December 18, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<RadioCard>の実装 (要<RadioButton>) <RadioButton>の実装
2 participants