textInput を実装 #61
Open
textInput を実装 #61
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cp-20
reviewed
Dec 26, 2024
| .text-input { | ||
| height: 32px; | ||
| border: none; | ||
| outline: 0; |
There was a problem hiding this comment.
[should] アクセシビリティの観点から outilne: 0 は外して欲しいです！ (どこにフォーカスが当たっているのかを分かりやすくするため)
| gap: 8px; | ||
| height: 32px; | ||
| align-items: center; | ||
| padding: 8px 16px; |
There was a problem hiding this comment.
[should] 外側の <div> に padding 付けちゃうと周辺のエリアが <input> じゃなくなっちゃうので、<input> の方の padding で対応して欲しいです！
| type="text" | ||
| class="text-input" | ||
| :size="props.size" | ||
| :placeholder="props.placeholder" |
There was a problem hiding this comment.
[imo] props.placeholder とかは placeholder ってした方が簡単に書けるかも
cp-20
reviewed
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button 要素ごと template で持ってくることを想定しています
入力欄とそのほかの区別がわかりづらいことがちょっと気になってるんですが、こういうもんなんでしょうか
close: #51