通知の対象者を表示 #917
Merged
通知の対象者を表示 #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
書いてから思ったんですが，既存のイベントが編集されるときはその時の参加欠席に基づいて通知が飛んでるような気がしてきました。 |
|
PRありがとうございます!
個人的には通知対象者を列挙するということにこだわらずに参加予定者をプレビュー時点で表示する機能ということでいいかなと思いました。 |
|
レビューありがとうございます！返信がとても遅くなり，大変申し訳ございません。 |
|
wasabiさんが提案してくださった内容をもとに，targets→inviteesにしました。 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
イベント作成時に通知が飛ぶ人を表示するようにしました。
現状対象グループのメンバーを表示しているのですが，何か例外はありますでしょうか。