Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:loading-barを追加 #966

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

mathsuky
Copy link
Contributor

@mathsuky mathsuky commented Aug 5, 2024

loading-barを用いて読み込み中であることを明示的にしました。

Copy link
Member

@itt828 itt828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
1点だけ修正してもらえばokです!

@@ -1,8 +1,10 @@
<template>
<v-col>
<v-progress-linear indeterminate color="primary"></v-progress-linear>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここだけ削除で

@mathsuky
Copy link
Contributor Author

レビューありがとうございます!修正してテストも通ったのでマージします

@mathsuky mathsuky merged commit 93b66e1 into master Aug 12, 2024
8 checks passed
@mathsuky mathsuky deleted the feat/add-progress-circular-to-calendar branch August 12, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants