Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/externalをinfrastructure/externalに移動 #588

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

ras0q
Copy link
Member

@ras0q ras0q commented Oct 27, 2023

  • ♻️ move interfaces/external to infrastructure/external
  • ♻️ change external mock from injector.go

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Files Coverage Δ
infrastructure/external/apiclient.go 0.00% <ø> (ø)
...astructure/external/mock_external_e2e/mock_knoq.go 100.00% <ø> (ø)
...tructure/external/mock_external_e2e/mock_portal.go 90.00% <ø> (ø)
...astructure/external/mock_external_e2e/mock_traq.go 95.00% <ø> (ø)
infrastructure/repository/contest_impl.go 96.86% <ø> (ø)
infrastructure/repository/event_impl.go 93.19% <ø> (-0.69%) ⬇️
infrastructure/repository/project_impl.go 100.00% <ø> (ø)
infrastructure/repository/user_impl.go 97.36% <ø> (ø)
util/mockdata/external.go 100.00% <ø> (ø)
infrastructure/external/traq.go 0.00% <0.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ras0q ras0q merged commit b609182 into main Oct 27, 2023
8 of 9 checks passed
@ras0q ras0q deleted the refactor/external-infra branch October 27, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant