-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ユーザーアカウントAPIのprPermittedに当たる要素を全て消した #739
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 70.93% 71.04% +0.10%
==========================================
Files 42 43 +1
Lines 4576 4572 -4
==========================================
+ Hits 3246 3248 +2
+ Misses 1172 1167 -5
+ Partials 158 157 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
差分だけ見ました
消し忘れてたらコンパイルエラー出るはずなので良さそうです
コメントのとこだけ命名直したらマージしちゃってください
} | ||
} | ||
|
||
type v3Account struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3以降のaccountsテーブルにはcheckカラムがないので若干違和感あります
v3PreAccountとかv3BeforeAccountとかにしとくとわかりやすそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あ、DBスキーマドキュメントの更新してなさそう
Readme見てそれだけやってほしいです
resolves #678
"prPermitted"とdatabaseのaccount.checkを消しました