Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザーアカウントAPIのprPermittedに当たる要素を全て消した #739

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tennessine699
Copy link
Contributor

resolves #678

"prPermitted"とdatabaseのaccount.checkを消しました

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.04%. Comparing base (adea612) to head (01e0906).

Files with missing lines Patch % Lines
internal/infrastructure/migration/v3.go 25.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
+ Coverage   70.93%   71.04%   +0.10%     
==========================================
  Files          42       43       +1     
  Lines        4576     4572       -4     
==========================================
+ Hits         3246     3248       +2     
+ Misses       1172     1167       -5     
+ Partials      158      157       -1     
Flag Coverage Δ
integration 71.04% <52.63%> (+0.10%) ⬆️
unit 71.04% <52.63%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono H1rono requested review from ras0q and H1rono December 14, 2024 13:30
Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

差分だけ見ました
消し忘れてたらコンパイルエラー出るはずなので良さそうです
コメントのとこだけ命名直したらマージしちゃってください

}
}

type v3Account struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3以降のaccountsテーブルにはcheckカラムがないので若干違和感あります
v3PreAccountとかv3BeforeAccountとかにしとくとわかりやすそう

Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、DBスキーマドキュメントの更新してなさそう
Readme見てそれだけやってほしいです

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

アカウントの広報公開設定を消す
2 participants