Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lintが落ちるので変数/引数名を修正 #2541

Merged
merged 1 commit into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions service/bot/ws/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ Command:
}
}

func (s *session) sendErrorMessage(error string) {
func (s *session) sendErrorMessage(messeage string) {
_ = s.WriteMessage(&rawMessage{
t: websocket.TextMessage,
data: makeErrorMessage(error).toJSON(),
data: makeErrorMessage(messeage).toJSON(),
})
}
8 changes: 4 additions & 4 deletions service/channel/tree_impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,14 @@ func (n *channelNode) getChildrenIDs() []uuid.UUID {
}

func (n *channelNode) getChannelDepth() int {
max := 0
maxDepth := 0
for _, c := range n.children {
d := c.getChannelDepth()
if max < d {
max = d
if maxDepth < d {
maxDepth = d
}
}
return max + 1
return maxDepth + 1
}

func (n *channelNode) getDescendantIDs() []uuid.UUID {
Expand Down
4 changes: 2 additions & 2 deletions service/ws/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,9 @@ Command:
}
}

func (s *session) sendErrorMessage(error string) {
func (s *session) sendErrorMessage(messeage string) {
_ = s.WriteMessage(&rawMessage{
t: websocket.TextMessage,
data: makeMessage("ERROR", error).toJSON(),
data: makeMessage("ERROR", messeage).toJSON(),
})
}
6 changes: 3 additions & 3 deletions utils/storage/s3_object_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func tests3ObjectSeek(t *testing.T) {
name string
setupFunc func(t *testing.T) *s3Object
args args
wantNewPos func(len, pos, offset int64) int64
wantNewPos func(length, pos, offset int64) int64
wantErr bool
}{
{
Expand Down Expand Up @@ -173,8 +173,8 @@ func tests3ObjectSeek(t *testing.T) {
offset: -1024,
whence: 2,
},
wantNewPos: func(len, _, offset int64) int64 {
return len + offset
wantNewPos: func(length, _, offset int64) int64 {
return length + offset
},
},
}
Expand Down