Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iPad miniのPWAでサービス一覧の表示が崩れる問題を修正 #4006

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

iPad miniのPWAでサービス一覧の表示が崩れる問題を修正 #4006

wants to merge 1 commit into from

Conversation

nokhnaton
Copy link
Contributor

fix: #4000

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4091f78) 86.34% compared to head (25bccb7) 86.34%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4006   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files          66       66           
  Lines        4709     4709           
  Branches      563      563           
=======================================
  Hits         4066     4066           
  Misses        637      637           
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mehm8128
mehm8128 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iPad miniでバグが直るのか僕は確認していないのですが、この修正によってPCとスマホ表示で不具合が発生していないことは確認できました

@nokhnaton
Copy link
Contributor Author

iPad miniで治ってるかは開発環境にマージしてiPad miniを持っている人に確認してもらおうと考えてます

@nokhnaton nokhnaton self-assigned this Jul 3, 2023
ras0q
ras0q reviewed Jul 16, 2023
View reviewed changes
Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

縦幅が小さいときにナビゲーションの左側がスクロールできなくなってそうです
iPhoneSEとiPhoneXRで確認しました
image

ras0q
ras0q requested changes Jul 16, 2023
View reviewed changes
Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マージできないようにRequestchangesにしとくか

@mehm8128
Copy link
Contributor

iPad miniで治ってるかは開発環境にマージしてiPad miniを持っている人に確認してもらおうと考えてます

プレビュー環境できたのでプレビュー環境で確認してもらうのがよさそう

@nokhnaton nokhnaton marked this pull request as draft October 30, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0q ras0q ras0q requested changes

@mehm8128 mehm8128 mehm8128 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@nokhnaton nokhnaton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipad miniのiOS safari 16.4.1でサービス一覧が上手く表示されない
3 participants
@nokhnaton @mehm8128 @ras0q