引用ブロックを折り畳めるように #4051
Merged
引用ブロックを折り畳めるように #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4051-prod.traq-preview.trapti.tech/ |
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
ras0q
reviewed
Sep 14, 2023
| <fold-button | ||
| v-if="oversized" | ||
| :is-fold="!isExpanded" | ||
| :class="$style.expandButton" |
There was a problem hiding this comment.
fold-buttonのstyleが$style.expandButtonなのかなり違和感あるけどしゃーなし？
FoldableCodeBlock.vueがfoldベースで書かれてるのでそっちに揃えてほしさがあります
There was a problem hiding this comment.
expand 系にしてた理由忘れたので fold で書き換えました
ちなみにどこに focus が当たって欲しいですか |
|
どこにもあたってほしくない(？) |
|
近くに focus がないとキーボード操作するときに終わりませんか |
|
traQからワープしました |
変えました refs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #801
高さとかは検索部分 (ref:
src/components/Main/CommandPalette/SearchResultMessageElement.vue) 準拠ですFigma: https://www.figma.com/file/6Wme6N24y3GN2jD0vqZWZr/traQ-S-UI?type=design&node-id=9539-23359&mode=dev