Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is typingじゃなくなるまでの時間を長くした #4236

Merged
merged 1 commit into from
May 5, 2024

Conversation

mehm8128
Copy link
Contributor

https://q.trap.jp/messages/3ac17569-885b-4eef-be62-3a12e3365a29

秒数に関してなんか意見ある人とかも教えてください

@mehm8128 mehm8128 self-assigned this Feb 16, 2024
Copy link

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f0340c) 0.00% compared to head (3f153df) 86.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4236       +/-   ##
===========================================
+ Coverage        0   86.36%   +86.36%     
===========================================
  Files           0       66       +66     
  Lines           0     4722     +4722     
  Branches        0      565      +565     
===========================================
+ Hits            0     4078     +4078     
- Misses          0      638      +638     
- Partials        0        6        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nokhnaton
Copy link
Contributor

個人的には3秒でも特に気になってなかったので変える理由がよくわかってないです。
別に10秒とかにしたところでそれ以上文章を書くのが止まることって頻繁にあると思いますし、flappingしたところでなにか問題があるとも思えないです。
まあ長くすることに反対する理由もないので、変えたい人が多いなら変えてもいいと思います

Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上に同じくですが強い反対もないのでapprove

@mehm8128 mehm8128 merged commit 8e7c016 into master May 5, 2024
12 checks passed
@mehm8128 mehm8128 deleted the fix/make_typing_timeout_longer branch May 5, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants