Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FormSelectorFilterable.vueを作成 #4244
FormSelectorFilterable.vueを作成 #4244
Changes from 31 commits
55af32a
a3cd02d
cd3942f
15a028c
c33c7e0
73a281c
029cadb
b2e511f
7801174
9ce174a
3c589f1
293fd4e
40fab8c
1a44478
98a546d
81bf201
8fa0c7a
21145bd
09e0c83
c5c83e0
846bfa5
566c6e9
7228d7d
00f0f62
0199331
c57394e
530394d
ccd4ad2
01ee435
08d37af
3fdd33c
a56db2b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
デフォルトがsecondaryで条件分岐でprimaryを当ててるのちょっと不自然なので、逆にした方がいいかもです
他のところも同様
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FormSelector.vueもそうなんですけど、primaryの上に置くことが多いのでデフォがsecondaryになってるんだと思います。なのでデフォはsecondaryにするのが自然かなーって思ってるんですけど、どうしましょう?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確かにそうかもです
このままで大丈夫そうです👍