💄 feat: スタンプを押した人と数の表示を変更 #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4320-prod.traq-preview.trapti.tech/ |
reiroop
changed the title
表示名で表示する際に名前の区切りがわかりづらくなるため、区切り文字として / を追加。表示名と見分けがつくように `@include color-ui-secondary-inactive` を適用。
StampDetailElementContent全体をflexにすることでスペースがなくなっていたのに対応した
区切り文字のスペースが少し大きかったため、を通常のスペースから少し狭いスペースに変更した。 またこれに伴い、StampDetailElement.vueでスペースを挿入していたのを削除した。
…lementに移動 スペース関連の定義を一つのファイルにまとめることで可読性を向上させることを目的とする。
paddingを用いることでクリック可能な領域が広がります。
anninさんのアドバイスにより変更
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4320 +/- ##
=======================================
Coverage 86.36% 86.36%
=======================================
Files 66 66
Lines 4722 4724 +2
Branches 565 566 +1
=======================================
+ Hits 4078 4080 +2
Misses 638 638
Partials 6 6 ☔ View full report in Codecov by Sentry. |
nokhnaton
reviewed
Jun 28, 2024
src/components/Main/MainView/MessageElement/StampDetailElement.vue
Outdated
Show resolved
Hide resolved
#4320 (comment) を参考に、src/lib/messageStampList.ts に StampRecordPerUser インターフェースの定義を作成し、src/components/Main/MainView/MessageElement/StampDetailElement.vue を修正した。
nokhnaton
reviewed
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.