Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アップデートtoastが出る条件を厳しく #4392

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

nokhnaton
Copy link
Contributor

これで完全に解決するかはわからない。
今までアップデートできていたものができなくなるというのはおそらくないだろうと思われる。

Copy link

Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです!

見た感じ、毎時 1 回サービスワーカーがチェックをかけるのはいいんですが、そのときに更新が見つからなくても更新をかけている (?) のはのが悪さしてそうでしたね
あと、2 回モーダルが出るのも、恐らく 2 つの条件を同時に満たすからっぽかったですね

@nokhnaton nokhnaton merged commit f5a0f67 into master Oct 28, 2024
10 checks passed
@nokhnaton nokhnaton deleted the fix/update_toast_show_often branch October 28, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants