Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL内のメンションは埋め込まれないように #4423

Merged
merged 7 commits into from
Dec 30, 2024
Merged

URL内のメンションは埋め込まれないように #4423

merged 7 commits into from
Dec 30, 2024

Conversation

cp-20
Copy link
Contributor

@cp-20 cp-20 commented Dec 16, 2024 •
edited
Loading

refer #3978

@cp-20 cp-20 requested a review from nokhnaton December 16, 2024 16:45
@github-actions GitHub Actions
Copy link

Preview (prod) → https://4423-prod.traq-preview.trapti.tech/
Preview (dev) → https://4423-dev.traq-preview.trapti.tech/

@nokhnaton
Copy link
Contributor

やろうとしてることはいい感じだと思います!
ただ正規表現がだいぶ複雑になってきてるので、URLを表す部分とそれ以外を分けたいなぁと思ってます。なので、正規表現オブジェクトのコンストラクタを使うようにするともっといいのかなと思います!
実装お願いできますか?

nokhnaton
nokhnaton approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです!:attoteki_kansya:

@nokhnaton nokhnaton merged commit a4134d1 into master Dec 30, 2024
9 checks passed
@nokhnaton nokhnaton deleted the fix/mention-embed-in-url branch December 30, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nokhnaton nokhnaton nokhnaton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-20 @nokhnaton