Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(langchain): return exports in langchain runnables module patch #470

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix(langchain): return exports in langchain runnables module patch #470

merged 1 commit into from
Oct 31, 2024

Conversation

anuraaga
Copy link
Contributor

Patch methods need to return moduleExports like the other ones, just this one seems to have missed it as a typo

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nirga
nirga approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @anuraaga!

@nirga nirga merged commit 23fdb28 into traceloop:main Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuraaga @CLAassistant @nirga