Create example Blazor WebAssembly project #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoXtreem
changed the title
hmG3
reviewed
Jan 15, 2020
| @@ -0,0 +1,16 @@ | |||
| using Microsoft.AspNetCore.Blazor.Hosting; | |||
|
|
|||
| namespace WebApplication1 | |||
There was a problem hiding this comment.
It would be clearer if the project's name matches the language of an example
Suggested change
| namespace WebApplication1 | |
| namespace BlazorWasmExample |
hmG3
reviewed
Jan 15, 2020
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width" /> | ||
| <title>WebApplication1</title> |
There was a problem hiding this comment.
Probably need change project's name string everywhere in the code
Suggested change
| <title>WebApplication1</title> | |
| <title>BlazorWasmExample</title> |
hmG3
reviewed
Jan 15, 2020
| <Project Sdk="Microsoft.NET.Sdk.Web"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>netstandard2.0</TargetFramework> |
There was a problem hiding this comment.
At the time being the current version of Blazor supports netstandard2.1
Suggested change
| <TargetFramework>netstandard2.0</TargetFramework> | |
| <TargetFramework>netstandard2.1</TargetFramework> |
hmG3
reviewed
Jan 15, 2020
Comment on lines
+27
to
+70
| var tvWidget = null; | ||
| window.tradingViewChartWrapper = { | ||
|
|
||
| initialize: function () { | ||
| const widgetOptions = { | ||
| symbol: 'AAPL', | ||
| // BEWARE: no trailing slash is expected in feed URL | ||
| datafeed: new window.Datafeeds.UDFCompatibleDatafeed('https://demo_feed.tradingview.com'), | ||
| interval: 'D', | ||
| container_id: 'tv_chart_container', | ||
| library_path: '/charting_library/', | ||
| locale: getLanguageFromUrl() || 'en', | ||
| disabled_features: ['use_localstorage_for_settings'], | ||
| enabled_features: ['study_templates'], | ||
| charts_storage_url: 'https://saveload.tradingview.com', | ||
| charts_storage_api_version: '1.1', | ||
| client_id: 'tradingview.com', | ||
| user_id: 'public_user_id', | ||
| fullscreen: false, | ||
| autosize: true, | ||
| studies_overrides: {} | ||
| }; | ||
|
|
||
| tvWidget = new TradingView.widget(widgetOptions); | ||
|
|
||
| tvWidget.onChartReady(() => { | ||
| tvWidget.headerReady().then(() => { | ||
| const button = tvWidget.createButton(); | ||
| button.setAttribute('title', 'Click to show a notification popup'); | ||
| button.classList.add('apply-common-tooltip'); | ||
| button.addEventListener('click', | ||
| () => tvWidget.showNoticeDialog({ | ||
| title: 'Notification', | ||
| body: 'TradingView Charting Library API works correctly', | ||
| callback: () => { | ||
| console.log('Noticed!'); | ||
| } | ||
| })); | ||
|
|
||
| button.innerHTML = 'Check API'; | ||
| }); | ||
| }); | ||
| } | ||
| }; |
There was a problem hiding this comment.
A better place to store the initialization script is a separate javascript file.
hmG3
reviewed
Jan 15, 2020
Comment on lines
+9
to
+12
| <PackageReference Include="Microsoft.AspNetCore.Blazor" Version="3.1.0-preview1.19508.20" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Blazor.Build" Version="3.1.0-preview1.19508.20" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Blazor.HttpClient" Version="3.1.0-preview1.19508.20" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Blazor.DevServer" Version="3.1.0-preview1.19508.20" PrivateAssets="all" /> |
There was a problem hiding this comment.
And all NuGet packages can be upgraded to latest preview 3.1.0-preview4.19579.2
hmG3
reviewed
Jan 15, 2020
Comment on lines
+1
to
+5
| { | ||
| "version": 1, | ||
| "dgSpecHash": "NDuF6YjtcCoYqH0XbROA+FgH7zDmqssPRAdSQCy8cZ7aXxpdQUXARuoTOz6FDYThRBRWOs3lpPIjDvsFSuQF3A==", | ||
| "success": true | ||
| } |
There was a problem hiding this comment.
/obj/ is a dynamically generated folder and should not be committed to a source control
hmG3
suggested changes
Jan 16, 2020
Nipheris
requested changes
Jan 16, 2020
| @@ -0,0 +1,24 @@ | |||
| <?xml version="1.0" encoding="utf-8" standalone="no"?> | |||
There was a problem hiding this comment.
This file is generated during package restore, it should be ignored from version control.
| @@ -0,0 +1,12 @@ | |||
| <?xml version="1.0" encoding="utf-8" standalone="no"?> | |||
There was a problem hiding this comment.
All the files in obj subdirectory are usually ignored from git.
|
Please, anyone, finish the merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example checklist