Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug output #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove debug output #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
827ac62
Remove debug output
n-rodriguez Sep 4, 2021
0d58b7d
Fix: ctx can be nil when calling `puts @normalizers[:endpoints].call(…
n-rodriguez Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/trailblazer/endpoint/controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def self.included(includer)
module Rails
module Process
def send_action(action_name)
puts "@@@@@>>>>>>> #{action_name.inspect}"
# puts "@@@@@>>>>>>> #{action_name.inspect}"

dsl = send(action_name) # call the actual controller action.

Expand Down
1 change: 1 addition & 0 deletions lib/trailblazer/endpoint/options.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def self.add(normalizer, directive_name, options)

def self.CallDirective(callable, option_name)
->((ctx, flow_options), *) {
ctx ||= {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ||= usually implies you have lost track of how your data flows, it's always an anti-pattern for me! In what cases is that required for you, if I may ask?

Also, off-topic, @n-rodriguez may I ask you some questions on https://trailblazer.zulipchat.com of how you use endpoint? Background is, I have another branch where I threw out a lot of complex logic of this gem and changed the runtime API and I'd like to hear a user's thoughts (and so far, you're the only user I know hahaha). ☕

Copy link
Author

@n-rodriguez n-rodriguez Apr 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what cases is that required for you, if I may ask?

For debugging :)

When I run this code without the patch (in config/puma.rb) :

before_fork do
  PumaSettings.info '* Finalizing master process'

  #puts CampingsController.instance_variable_get('@normalizers')[:endpoints].call([]).inspect
  puts ConcertoFrance::PagesController.instance_variable_get('@normalizers')[:endpoints].call([]).inspect

  3.times { GC.start }
  GC.compact

  #puts CampingsController.instance_variable_get('@normalizers')[:endpoints].call([]).inspect
  puts ConcertoFrance::PagesController.instance_variable_get('@normalizers')[:endpoints].call([]).inspect
end

it fails with this error :

/Users/nicolas/PROJECTS/CONCERTO/concerto/.bundle/ruby/3.3.0/bundler/gems/trailblazer-endpoint-827ac62bdb4c/lib/trailblazer/endpoint/options.rb:80:in `block in CallDirective': no implicit conversion of nil into Hash (TypeError)

          config = callable.(ctx, **ctx) # e.g. ApplicationController.options_for_endpoint

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this patch we can see the Ruby GC bug : trailblazer/trailblazer-activity#60 (comment)

config = callable.(ctx, **ctx) # e.g. ApplicationController.options_for_endpoint

# ctx[option_name] = ctx[option_name].merge(config)
Expand Down