Example Dockerfile fixes for PolyTracker short tool paper #6570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le, so turn off old python check - I think our switching to python3.10 only results in this environmental difference
…ound the time when we made the Dockerfile, and building in the correct location
…and uglier than I'd prefer
kaoudis
commented
Jul 3, 2024
| RUN git clone https://github.com/file/file.git | ||
| WORKDIR /polytracker/the_klondike/file | ||
| RUN git fetch --tags && \ | ||
| git checkout tags/FILE5_41 |
There was a problem hiding this comment.
this just pins a file version that seems compatible with when this dockerfile was originally created. I dont think we pinned a version before.
kaoudis
commented
Jul 3, 2024
| RUN wget http://xmlsoft.org/sources/libxml2-2.9.10.tar.gz | ||
| RUN tar -xvf libxml2-2.9.10.tar.gz | ||
| WORKDIR libxml2-2.9.10 | ||
| RUN wget http://xmlsoft.org/sources/libxml2-2.9.11.tar.gz |
There was a problem hiding this comment.
was getting a Python macro error with previous version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dead sources links and WORKDIR assumptions, as well as missing dependencies, for some of the example builds. This gave me the ability to build and gather data from the following:
Remainder that error out for missing dependency or build failure reasons before we get to instrumentation: