added try catch to handle not found

traleor · Aug 30, 2023 · e84c1ad · e84c1ad
1 parent b1ebcaf
commit e84c1ad
Show file tree

Hide file tree

Showing 2 changed files with 63 additions and 43 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -108,20 +108,26 @@ export class CMSClient {
         };
       }
     } else {
-      const response = (await this.fetchContent(
-        `${contentType}/${idOrSlug}`,
-        queries,
-        headers,
-        cache
-      )) as CMSContent;
-
-      if (response.id && response.title) {
-        return response;
-      } else {
-        return {
-          message: "Page not found",
-          data: response,
-        };
+      try {
+        return (await this.fetchContent(
+          `${contentType}/${idOrSlug}`,
+          queries,
+          headers,
+          cache
+        )) as CMSContent;
+      } catch (error) {
+        if (error instanceof FetchError) {
+          return {
+            message: "Page not found",
+            data: error,
+          };
+        } else {
+          console.error("An unknown error occurred:", error);
+          return {
+            message: "An unknown error occurred:",
+            data: error,
+          };
+        }
       }
     }
   }
@@ -143,20 +149,26 @@ export class CMSClient {
     cache?: RequestCache
   ): Promise<CMSContent | NotFoundContents> {
     const contentType = "images";
-    const response = (await this.fetchContent(
-      `${contentType}/${id}`,
-      queries,
-      headers,
-      cache
-    )) as CMSContent;
-
-    if (response.id && response.title) {
-      return response;
-    } else {
-      return {
-        message: "Image not found",
-        data: response,
-      };
+    try {
+      return (await this.fetchContent(
+        `${contentType}/${id}`,
+        queries,
+        headers,
+        cache
+      )) as CMSContent;
+    } catch (error) {
+      if (error instanceof FetchError) {
+        return {
+          message: "Image not found",
+          data: error,
+        };
+      } else {
+        console.error("An unknown error occurred:", error);
+        return {
+          message: "An unknown error occurred:",
+          data: error,
+        };
+      }
     }
   }
 
@@ -177,20 +189,26 @@ export class CMSClient {
     cache?: RequestCache
   ): Promise<CMSContent | NotFoundContents> {
     const contentType = "documents";
-    const response = (await this.fetchContent(
-      `${contentType}/${id}`,
-      queries,
-      headers,
-      cache
-    )) as CMSContent;
-
-    if (response.id && response.title) {
-      return response;
-    } else {
-      return {
-        message: "Document not found",
-        data: response,
-      };
+    try {
+      return (await this.fetchContent(
+        `${contentType}/${id}`,
+        queries,
+        headers,
+        cache
+      )) as CMSContent;
+    } catch (error) {
+      if (error instanceof FetchError) {
+        return {
+          message: "Document not found",
+          data: error,
+        };
+      } else {
+        console.error("An unknown error occurred:", error);
+        return {
+          message: "An unknown error occurred:",
+          data: error,
+        };
+      }
     }
   }
 

diff --git a/src/types/index.d.ts b/src/types/index.d.ts
@@ -1,3 +1,5 @@
+import { FetchError } from "..";
+
 export interface ClientOptions {
   baseURL: string;
   apiPath: string;
@@ -60,5 +62,5 @@ export interface CMSContents {
 
 export interface NotFoundContents {
   message: string;
-  data: CMSContent| CMSContents;
+  data: CMSContent | CMSContents | FetchError | unknown;
 }