Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-B-21577 Limit UB weight allowance based on Student Travel order type. #14285

Open
wants to merge 3 commits into
base: integrationTesting
Choose a base branch
from

Conversation

brooklyn-welsh
Copy link
Contributor

@brooklyn-welsh brooklyn-welsh commented Nov 26, 2024

Agility ticket

Summary

This branch limits the "Unaccompanied Baggage Weight" limit for a move to 350 lbs if the move order is of the "Student Travel" type. Note that currently there is no validation to ensure that Student Travel is only eligible for OCONUS moves, but since the intention is that this will only be an option for OCONUS, this weight limit functionality only works if you choose an origin or destination duty location that is OCONUS (e.g. Alaska).

How to test

  1. Enable the "FEATURE_FLAG_UNACCOMPANIED_BAGGAGE" FF in the .envrc and re-run make server_run
  2. Create a move with an OCONUS origin/destination duty location (I used Tok, AK)
  3. Create a UB Unaccompanied baggage shipment. (This weight limiting will work with any shipment type since it's on the order level, but the UB shipment gives us an extra UI spot to verify that the limiting is working).
  4. Sign for the move, then login as SC and access the move, you should see on the "Allowances" card that the "Unaccompanied Baggage" field shows 350 lbs:Screenshot 2024-11-26 at 3 07 48 PM
  5. Also check the shipment by clicking "Edit Shipment" on the UB shipment card, then verify that this also shows 350 lbs:
    Screenshot 2024-11-26 at 3 10 08 PM

P.S. you can also create moves without UB and instead have any other shipment type, and you should still see the "Allowances" card show 350 lbs as shown in step 4, you just won't get the UB shipment card as shown in step 5.

@brooklyn-welsh brooklyn-welsh added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Nov 26, 2024
@brooklyn-welsh brooklyn-welsh marked this pull request as ready for review November 26, 2024 21:57
Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason when I make a UB move the ub weight allowance is 500lb and a dash if its an HHG shipment.

Screenshot 2024-11-26 at 4 39 50 PM

I'm gonna attempt a re review tomorrow in case its just something I'm doing wrong

Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I was sleep with my eyes open yesterday. Looks Good!

Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brooklyn-welsh brooklyn-welsh requested a review from a team December 2, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

3 participants