DRAFT FOR FEEDBACK - Main b 21669 doc viewer file upload status per s3 events #14347
+1,687
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oc_viewer_file_upload_status_per_s3_events
ryan-mchugh
changed the title
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
ryan-mchugh
requested review from
deandreJones,
cameroncaci,
samaysofo,
stevengleason-caci and
brianmanley-caci
pkg/handlers/internalapi/uploads.go
Outdated
| f.Flush() | ||
| } | ||
|
|
||
| time.Sleep(4 * time.Second) |
There was a problem hiding this comment.
Should this delay, and the number of retries, be an environment setting or something?
There was a problem hiding this comment.
Will consider this for # of retries on upcoming changes.
| useEffect(() => { | ||
| if (fileStatus === 'ESTABLISHING') { | ||
| new Promise((resolve) => { | ||
| setTimeout(resolve, 5000); |
There was a problem hiding this comment.
Wait 5 seconds and then say it's Loaded; is this going to be replaced with some other check?
There was a problem hiding this comment.
Just mocked for now
…oc_viewer_file_upload_status_per_s3_events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21669 - Orders Edit- Document Viewer- Show Order viewer uploaded file
DRAFT
A mock-up for server-side events for future integration of S3 notification listeners. Publish/subscribe to the notification, send that "doc status" back to the client.
Please leave feedback and suggestions for properly structuring the "WriteReponse" call. Currently using a custom response to go around the generated type to keep open the response thread and respond over time (Server-side events).
Stepping away from this story for the time being to work on the lambda.
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots