B 21490 INT - Secondary Transportation Offices - Increase Test Coverage

[ajlusk]

Agility ticket

Summary

I don't think this BL's changes are the straw that broke the server test coverage but there was some low hanging fruit to increase coverage. Some tests are directly related to B-21490 but many are only adjacent (tests stuff used by but not added by 21490/92) to get make up that 0.2% difference.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Tests passing?
2. Test coverage passing, is it at 76.3 rather than 76.1 or 76.2?

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[MInthavongsay]

Looks good!

[antgmann]

From my understanding of this area of the application, these tests look good. However, the commented test in pkg/handlers/adminapi/office_users_test.go needs adjusted.

[antgmann]

Requested change made 😎

[r-mettler]

looks good