Migrate client proxies for http-proxy-middleware 2.0.6 to 3.0.3 - Remove wild cards/Fix Logout 404 #14443
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
ajlusk
changed the title
|
@ajlusk @danieljordan-caci @taeJungCaci @loganwc @paulstonebraker is this ready to go.. ?? |
No idea, but I like this one because the wildcards are taken out |
danieljordan-caci
approved these changes
Jan 6, 2025
deandreJones
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR
Summary
Removes the wild cards that came with our 2.0 syntax because they are causing a 404 when attempting to logout.
With the wild cards and a logger turned on I was seeing requests to
/auth/**/logout.From what I can tell from the commit history and docs of old versions of libraries the wild cards were never really necessary.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots
Log result with both wild cards, the first one appears to truncate anything after
/authand the second one just acts as plain text.Log result with just the first wild card, as mentioned above, results in dropping everything after
/auth.Log result with just the second wild card, acting as plain text,
Log result with no wildcards == desired behavior == this PR.
Log result before the library upgrade, the logging changed too but matches the behavior in this PR.
