-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-21683 #14507
Merged
Merged
MAIN B-21683 #14507
+486
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljordan-caci
requested review from
deandreJones,
TevinAdams,
cameroncaci and
traskowskycaci
January 3, 2025 14:18
cameroncaci
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POA'd and commits are good
traskowskycaci
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed files match up!
rerunning ci/cd, flaky failure on required step |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT PR
Agility ticket
Summary
This one is kind of a bear to test because we are lacking some handy functionality to populate
us_post_region_cities_id
andpod_location
andpoe_location
, so there's some manual lifting on the frontend. Sorry..We need to populate estimated pricing for service items related to iHHG and iUB shipments. This PR handles creating a stored proc that will do the heavy lifting for us. Please review thoroughly since this involves $$$$.
How to test
Manually run this in DBeaver (not yet merged into INT)
us_post_region_cities_id
valuepricing_estimate
isnull
for eachpoe/pod_location_id
to this:43efe04d-0ca0-4571-9aa1-747193285d9e
prime_estimated_weight
to something. If there is no estimated weight, then we cannot give an estimated price.pricing_estimate
columns populate for each service itemmto_shipments
and manually change the shipment statusAPPROVED
(this isn't super necessary but feels wrong to not do)