Revert "B 21583 int" #14508
Merged
Revert "B 21583 int" #14508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pambecker
requested review from
danieljordan-caci,
paulstonebraker,
loganwc,
joeydoyecaci and
JonSpight
danieljordan-caci
previously approved these changes
Jan 3, 2025
paulstonebraker
previously approved these changes
Jan 3, 2025
loganwc
previously approved these changes
Jan 3, 2025
deandreJones
requested changes
Jan 3, 2025
There was a problem hiding this comment.
deleting the migration file doesn't undo the run of the migration in loadtest- you will have to create a new to put those back that was removed from
delete from postal_code_to_gblocs where postal_code in (
select uspr_zip_id from v_locations where state = 'AK');
also wouldn't remove the changes made to the move_to_gbloc view- need to replace it with the original implementation to correct
pambecker
dismissed stale reviews from loganwc, paulstonebraker, and danieljordan-caci
via
69e1c65
|
Ok, this PR is ready again, had to add data back to postal_code_to_gblocs and change the move_to_gbloc view back to the old way. |
danieljordan-caci
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14451
I goofed, didn't realize this broke on picking AK destination gbloc