Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21937: Allow Doc Uploads/Downloads with Commas #14509

Merged
merged 7 commits into from
Jan 6, 2025
Merged

B-21937: Allow Doc Uploads/Downloads with Commas #14509

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
57fedfb
Double quote filename to account for filenames with commas
TevinAdams Jan 3, 2025
73f738c
Merge branch 'B-21937-Doc-Uploads-Main' into B-21937-Doc-Uploads-Int
TevinAdams Jan 3, 2025
c46781e
Merge branch 'integrationTesting' into B-21937-Doc-Uploads-Int
TevinAdams Jan 3, 2025
94e1df0
Merge branch 'integrationTesting' into B-21937-Doc-Uploads-Int
TevinAdams Jan 3, 2025
c32a85f
Test updates and additions
TevinAdams Jan 3, 2025
7419b1b
Test adjustments
TevinAdams Jan 6, 2025
73747e4
Merge branch 'integrationTesting' into B-21937-Doc-Uploads-Int
TevinAdams Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/storage/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"io"
"path"
"strconv"
"time"

"github.com/aws/aws-sdk-go-v2/aws"
Expand Down Expand Up @@ -116,9 +117,11 @@ func (s *S3) TempFileSystem() *afero.Afero {
func (s *S3) PresignedURL(key string, contentType string, filename string) (string, error) {
namespacedKey := path.Join(s.keyNamespace, key)
presignClient := s3.NewPresignClient(s.client)
// Double quote the filename to be able to handle filenames with commas in them
quotedFilename := strconv.Quote(filename)
brianmanley-caci marked this conversation as resolved.
Show resolved Hide resolved

filenameBuffer := make([]byte, 0)
for _, r := range filename {
for _, r := range quotedFilename {
if encodedRune, ok := charmap.ISO8859_1.EncodeRune(r); ok {
filenameBuffer = append(filenameBuffer, encodedRune)
}
Expand Down
Loading