Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 22055 int #14517

Merged
merged 5 commits into from
Jan 7, 2025
Merged

B 22055 int #14517

merged 5 commits into from
Jan 7, 2025

Conversation

antgmann
Copy link
Contributor

@antgmann antgmann commented Jan 6, 2025

B-22055

Summary

This is a very simple easy-peasy backlog that reorders the appearance of shipment vs counseling QAE reports.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

  1. Access the office application as a new or existing QAE user.
  2. Login and search for a move, any will do. AMDORD is the one I used when completing this task.
  3. Open the move page, ensure the QAE tab is ordered correctly.
  4. If you'd like, feel free to add a couple reports and see them displayed correctly.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Screenshots

Before changes:
image

After changes:
image

ANDI is the exact same as no components were changed, just reordered:
image

@antgmann antgmann added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing frontend labels Jan 6, 2025
@antgmann antgmann self-assigned this Jan 6, 2025
@antgmann antgmann requested a review from a team as a code owner January 6, 2025 14:42
Copy link
Contributor

@r-mettler r-mettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good

Copy link
Contributor

@MInthavongsay MInthavongsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meet Acceptance Criteria. I see no issues.

@antgmann antgmann merged commit 45ab36a into integrationTesting Jan 7, 2025
31 of 34 checks passed
@antgmann antgmann deleted the B-22055-INT branch January 7, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

5 participants