Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21581 #14521

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

B-21581 #14521

wants to merge 5 commits into from

Conversation

WeatherfordAaron
Copy link
Contributor

@WeatherfordAaron WeatherfordAaron commented Jan 6, 2025

Agility Ticket B-21581

INT PR 14127

Testing Steps I took

Use this doc to determine what zip codes to use in order to see different GBLOCs.

  1. As a service member (to include CIV or other), create a move with a shipment. Pay special attention to what selection is made for your origin duty location.
  2. As SC and/or TOO verify which GBLOC shows up in the Origin GBLOC column for the move when you search for it. Also verify that when you open the move as an office user, the GBLOC should also show in the top-right of the page as you are looking at the move/shipment.
  3. As either the service member or as an office user, change the origin duty location to that which falls under a different GBLOC (reference the document link above which is from the helpful files section of the ByteSize M&Ms Confluence pages).
  4. As SC and/or TOO verify that the GBLOC has changed.

@WeatherfordAaron WeatherfordAaron added ByteSize M&Ms Team ByteSized M&Ms MAIN labels Jan 6, 2025
@WeatherfordAaron WeatherfordAaron self-assigned this Jan 6, 2025
@WeatherfordAaron WeatherfordAaron changed the title brought in changes done on PR 14127 B-21581 Jan 6, 2025
@WeatherfordAaron WeatherfordAaron marked this pull request as ready for review January 7, 2025 17:14
@WeatherfordAaron WeatherfordAaron requested a review from a team as a code owner January 7, 2025 17:14
pkg/models/errors.go Show resolved Hide resolved
Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of that missing file tae pointed out everything else looks good to me. I'll approve once that's added in

@WeatherfordAaron
Copy link
Contributor Author

Outside of that missing file tae pointed out everything else looks good to me. I'll approve once that's added in

Sweet. Just made the change and pushed @taeJungCaci and @KonstanceH

@taeJungCaci
Copy link
Contributor

Outside of that missing file tae pointed out everything else looks good to me. I'll approve once that's added in

Sweet. Just made the change and pushed @taeJungCaci and @KonstanceH

I thought you are gonna be merging in the other PR first? Is that not the case anymore?

@WeatherfordAaron WeatherfordAaron changed the title B-21581 B-21675 Jan 7, 2025
@WeatherfordAaron WeatherfordAaron changed the title B-21675 B-21581 Jan 7, 2025
Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms MAIN
Development

Successfully merging this pull request may close these issues.

3 participants