Skip to content

Commit

Permalink
Incorporate only used connectors into main codebase (#1178)
Browse files Browse the repository at this point in the history
  • Loading branch information
louis-pie authored Aug 28, 2024
1 parent 04a66fb commit 3ac5193
Show file tree
Hide file tree
Showing 555 changed files with 72,654 additions and 4,791 deletions.
19 changes: 0 additions & 19 deletions .github/ISSUE_TEMPLATE.md

This file was deleted.

40 changes: 0 additions & 40 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.md

This file was deleted.

20 changes: 0 additions & 20 deletions .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md

This file was deleted.

10 changes: 0 additions & 10 deletions .github/ISSUE_TEMPLATE/QUESTION.md

This file was deleted.

5 changes: 0 additions & 5 deletions .github/ISSUE_TEMPLATE/config.yml

This file was deleted.

10 changes: 1 addition & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
## Problem
## Context

_Describe the problem your PR is trying to solve_

## Proposed changes

_Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue. Please give a more detailed description on the test scenarios you covered for, if making a more impactful change._


## Types of changes

Expand All @@ -26,8 +21,5 @@ _Put an `x` in the boxes that apply_
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] Unit tests for changes (not needed for documentation changes)
- [ ] CI checks pass with my changes
- [ ] Bumping version in `setup.py` is an individual PR and not mixed with feature or bugfix PRs
- [ ] Commit message/PR title starts with `[AP-NNNN]` (if applicable. AP-NNNN = JIRA ID)
- [ ] Branch name starts with `AP-NNN` (if applicable. AP-NNN = JIRA ID)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions
2 changes: 1 addition & 1 deletion .github/workflows/connectors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:

- name: Check all connectors are installable
run: |
make all_connectors -e pw_acceptlicenses=y
make all_connectors
41 changes: 0 additions & 41 deletions .github/workflows/e2e_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -271,44 +271,3 @@ jobs:
-e TAP_S3_CSV_AWS_SECRET_ACCESS_KEY=$TAP_S3_CSV_AWS_SECRET_ACCESS_KEY \
-e TAP_S3_CSV_BUCKET=$TAP_S3_CSV_BUCKET \
pipelinewise_dev pytest tests/end_to_end/target_snowflake/tap_mongodb -vx --timer-top-n 10
e2e_tests_other_targets:
runs-on: ubuntu-20.04
environment: ci_tests

steps:
- name: Checking out repo
uses: actions/[email protected]

- name: Check if python changes are present
id: check
env:
GITHUB_REPO: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number }}
continue-on-error: true
run: ./scripts/ci_check_no_file_changes.sh python

- name: Setup test containers
if: steps.check.outcome == 'failure'
run: |
cp dev-project/.env.template dev-project/.env
docker compose -f dev-project/docker-compose.yml up -d
- name: Wait for test containers to be ready
if: steps.check.outcome == 'failure'
timeout-minutes: 5
run: |
until docker logs pipelinewise_dev | grep "PipelineWise Dev environment is ready"
do
echo 'Sleeping for 10s';
sleep 10;
done
- name: Run target bigquery and redshift end-to-end tests
if: steps.check.outcome == 'failure'
run: |
docker exec -t \
-e TAP_S3_CSV_AWS_KEY=$TAP_S3_CSV_AWS_KEY \
-e TAP_S3_CSV_AWS_SECRET_ACCESS_KEY=$TAP_S3_CSV_AWS_SECRET_ACCESS_KEY \
-e TAP_S3_CSV_BUCKET=$TAP_S3_CSV_BUCKET \
pipelinewise_dev pytest tests/end_to_end -vx --ignore=tests/end_to_end/test_target_postgres.py --ignore=tests/end_to_end/target_snowflake --timer-top-n 10
10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
0.65.0 (2024-08-27)
-------------------
- Remove FastSync for target Redshift
- Remove FastSync for target Bigquery
- Incorporate used singer connectors into main codebase
- Reduce testing codebase
- Simplify Makefile

0.64.1 (2024-07-25)
-------------------
- Remove row count check in `sync_tables` for `tap_mysql` and `tap_postgres`
Expand All @@ -6,7 +14,7 @@
-------------------
- Update `sync_tables` and `import_config` commands
- new optional config setting for source tables size checking
- checking the size of source tables in `tap_mysql` and `tap_postgres` to `target_snowflake` and failing fast sync
- checking the size of source tables in `tap_mysql` and `tap_postgres` to `target_snowflake` and failing fast sync
if the size is not allowed
- added `--force` argument for `sync_tables` command to ignore size checking

Expand Down
Loading

0 comments on commit 3ac5193

Please sign in to comment.