Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer SSL connection to Postgres and MariaDB sources #1157

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

louis-pie
Copy link
Contributor

@louis-pie louis-pie commented May 9, 2024

Context

AP-1693
It makes sense to switch on SSL authentication on data source.
This PR improves PipelineWise to Prefer SSL connections to Postgres and MariaDB sources.
If SSL connections cannot be made, regular connections will be made.

Proposed changes

  • Update local-dev environment to enforce SSL on PG and Maria sources
  • Update automated tests to connect using SSL
  • Update PG code to prefer SSL
  • Update Maria code to prefer SSL

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@wise-github-bot-app
Copy link

🔴

Your CODEOWNERS file is broken, fix the following errors before merging the branch:

  • The CODEOWNERS file does not exist. Repository ownership will default to ENGINEERING until you add a CODEOWNERS file with a * rule that assigns it to a team

amofakhar
amofakhar previously approved these changes May 10, 2024
@louis-pie louis-pie merged commit f41c89f into master May 16, 2024
17 of 18 checks passed
@louis-pie louis-pie deleted the AP-1693 branch May 16, 2024 16:59
@wise-github-bot-app
Copy link

Your CODEOWNERS or the tw-rules.yaml file has changed. Syncing your GitHub teams with your CODEOWNERS file and extraWriters in tw-rules:

Collaborator Name Synced Comment
analytics-platform 🟢 Team updated with role owner
@tw-census 🟢 User added with role admin

You have more info in the docs

@transferwise transferwise deleted a comment from wise-github-bot-app bot May 16, 2024
@transferwise transferwise deleted a comment from wise-github-bot-app bot May 16, 2024
@transferwise transferwise deleted a comment from wise-github-bot-app bot May 16, 2024
@transferwise transferwise deleted a comment from wise-github-bot-app bot May 16, 2024
@transferwise transferwise deleted a comment from wise-github-bot-app bot May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants