Merge pull request #9 from transitland/fix-name-defaults

Change base Entity name() and id() to return None instead of NotImplementedError

mzgtfs/entity.py

@@ -30,6 +30,9 @@ def __init__(self, **data):
     self._children = set()  
     self._parents = set()
 
+  def __repr__(self):
+    return '<%s %s>'%(self.__class__.__name__, self.id())
+
   # GTFS row data.
   def __len__(self):
     return len(self.data)
@@ -77,11 +80,11 @@ def items(self):
   # Name methods.
   def name(self):
     """A reasonable name for the entity."""
-    raise NotImplementedError
+    return None
 
   def id(self):
     """An internal GTFS identifier, e.g. route_id."""
-    raise NotImplementedError
+    return None
 
   def feedid(self, feedid):
     """A canonical Onestop-style ID for this entity."""

mzgtfs/test_entity.py

@@ -60,13 +60,11 @@ def test_setitem_ntconvert(self):
 
   def test_name(self):
     entity = entities.Entity(**self.expect)
-    with self.assertRaises(NotImplementedError):
-      entity.name()
+    assert entity.name() is None
 
   def test_id(self):
     entity = entities.Entity(**self.expect)
-    with self.assertRaises(NotImplementedError):
-      entity.id()
+    assert entity.id() is None
 
   def test_point(self):
     entity = entities.Entity(**self.expect)