feat(webdav): initial implementation for a WebDAV simple auth provider #5528

dschmidt · 2024-11-28T14:01:48Z

As #4621 got stale and @Murderlon suggested to implement only the SimpleAuth part of it... here we go.

I intentionally left out any visual configuration for now, I would like to get the actual functionality merged asap and deal with everything else in a followup.

I couldn't make the translations work (at least not the ones in the AuthForm) in the dev server, any hints for that?
Otherwise it works for me (tm)

dschmidt · 2024-11-28T14:19:17Z

Seen the type errors ... will fix tomorrow

dschmidt · 2024-11-29T10:09:11Z

@Murderlon fixed the type issues, but I'm clueless about the compare_diff test... it looks like new dependencies should be installed by

uppy/.github/workflows/e2e.yml

Lines 110 to 114 in 44a378a

    
                     corepack yarn workspaces focus $(\ 
        
                       corepack yarn workspaces list --json | \ 
        
                       jq -r .name | \ 
        
                       awk '/^@uppy-example/{ next } { if ($0!="uppy.io") print $0 }'\ 
        
                     )

but it doesn't seem to work?

Murderlon

Looks good overall! Thanks a lot for picking this up 👌

packages/@uppy/companion/src/server/provider/webdav/common.js

packages/@uppy/companion/src/server/provider/webdav/index.js

packages/@uppy/webdav/package.json

packages/@uppy/webdav/src/Webdav.tsx

Murderlon · 2024-12-02T09:18:22Z

I'm clueless about the compare_diff test

Perhaps reverting your changes for the action and resolving #5528 (comment) will help

…provider

dschmidt · 2024-12-02T11:28:43Z

I'm clueless about the compare_diff test

Perhaps reverting your changes for the action and resolving #5528 (comment) will help

I'm afraid I can't easily change that (as commented above) - do you have any other ideas?
Also I'm still struggling with the translations as written in the PR text - any ideas here?

Apart from that everything seems to work and I've addressed all your comments (I think), thanks for the feedback!

Murderlon · 2024-12-02T12:14:03Z

I'm afraid I can't easily change that (as commented above) - do you have any other ideas?
Also I'm still struggling with the translations as written in the PR text - any ideas here

I can take a look later

Murderlon · 2024-12-02T14:14:54Z

I can't make changes because you don't allow edits from contributors.

Try to add this to .github/workflows/e2e.yml (line 127)

        run: |
          git checkout FETCH_HEAD -- packages
+     - run: corepack yarn install
      - run: corepack yarn build:js:typeless

dschmidt · 2024-12-02T14:32:29Z

I can't make changes because you don't allow edits from contributors.

Maybe that's because I've sent the PR from the owncloud organization... mh :-\

Try to add this to .github/workflows/e2e.yml (line 127)

        run: |
          git checkout FETCH_HEAD -- packages
+     - run: corepack yarn install
      - run: corepack yarn build:js:typeless

Still failing :-\

Murderlon · 2024-12-05T13:26:53Z

Let's undo f657f79 and I'll merge it. I'm pretty sure it's just problematic for PRs introducing a new dependency, which I can sort out in main and doesn't have to block this PR.

mifi

Nice stuff!

Should we have an e2e test for this or would that be very hard to implement? maybe there's a simple mock webdav server implemented in node.js or we can apt install a webdav server and start it up in cypress?
should we have docs at https://github.com/transloadit/uppy.io ?
ui not pretty but I guess we can merge it as-is for now. at least it works

mifi · 2024-12-06T10:52:11Z

packages/@uppy/companion/src/server/provider/webdav/index.js

+          requestPath, // TODO FIXME
+          modifiedDate: item.lastmod, // TODO FIXME: convert  'Tue, 04 Jul 2023 13:09:47 GMT' to  ISO 8601


these should be fixed (or removed if not in use)

Suggested change

requestPath, // TODO FIXME

modifiedDate: item.lastmod, // TODO FIXME: convert 'Tue, 04 Jul 2023 13:09:47 GMT' to ISO 8601

mifi · 2024-12-06T10:52:36Z

packages/@uppy/companion/src/server/provider/webdav/index.js

+    throw new Error('call to thumbnail is not implemented')
+  }
+
+  // todo fixme implement


Suggested change

// todo fixme implement

mifi · 2024-12-06T10:55:38Z

packages/@uppy/companion/src/server/provider/webdav/index.js

+    const HttpAgentClass = getProtectedHttpAgent({ protocol, allowLocalIPs: !allowLocalUrls })
+
+    // dynamic import because Comanion currently uses CommonJS and webdav is shipped as ESM
+    // can be implemented as regular require as soon as Node 20.17 or 22 is required


Suggested change

// can be implemented as regular require as soon as Node 20.17 or 22 is required

// todo implement as regular require as soon as Node 20.17 or 22 is required

not to myself: oops, there's also a typo "Comanion"

mifi · 2024-12-06T11:06:59Z

packages/@uppy/webdav/src/Webdav.tsx

+  const onSubmit = (event) => {
+    event.preventDefault()
+    onAuth({ webdavUrl: webdavUrl.trim() })
+  }


usecallback to prevent unnecessary re-renders?

Suggested change

const onSubmit = (event) => {

event.preventDefault()

onAuth({ webdavUrl: webdavUrl.trim() })

}

const onSubmit = useCallback((e) => {

e.preventDefault()

onAuth({ webdavUrl: webdavUrl.trim() })

}, [onAuth, webdavUrl])

haha, @Murderlon told me to remove the useCallback we had in place before...

useCallback/useMemo are overused and should only be leveraged if you know something is slow, not just for the sake of it.

when coding it's not always obvious that something is going to become slow once it's in production with real world data. IMO it's safer to just add a useCallback than to find out by surprise later that your app is re-rendering the whole React tree on every key stroke in an <input> for example.

.github/workflows/e2e.yml

Co-authored-by: Mikael Finstad <[email protected]>

dschmidt · 2024-12-06T13:51:51Z

I will address @mifi 's comments asap, not sure what to do with the useCallback ... and I still need help with the translations, any hints?

Murderlon · 2024-12-06T13:54:46Z

I still need help with the translations, any hints?

I'm traveling and away from my laptop till 16 December. @mifi would be great if you can help get this over the finish line.

mifi · 2024-12-07T05:45:38Z

I don't think you need to translate anything. You've added them English keys, and AFAIK it will fallback to those.

dschmidt · 2024-12-07T16:28:29Z

But it doesnt work! The keys are not picked up is what I'm saying

dschmidt force-pushed the webdav-public-link-import branch from 52e2882 to ef88405 Compare November 29, 2024 09:55

Murderlon requested a review from mifi December 2, 2024 09:03

Murderlon reviewed Dec 2, 2024

View reviewed changes

dschmidt added 2 commits December 2, 2024 12:15

feat(webdav): initial implementation for a WebDAV simple auth provider

105b2ed

fixup! feat(webdav): initial implementation for a WebDAV simple auth …

1bbe4f8

…provider

dschmidt force-pushed the webdav-public-link-import branch from 0eea4ee to 1bbe4f8 Compare December 2, 2024 11:15

refactor(webdav): remove left overs from oauth provider

8f3cbe5

try to fix e2e pipelines

f657f79

Murderlon approved these changes Dec 5, 2024

View reviewed changes

mifi reviewed Dec 6, 2024

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

Update .github/workflows/e2e.yml

a4797cc

Co-authored-by: Mikael Finstad <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(webdav): initial implementation for a WebDAV simple auth provider #5528

feat(webdav): initial implementation for a WebDAV simple auth provider #5528

dschmidt commented Nov 28, 2024

dschmidt commented Nov 28, 2024

dschmidt commented Nov 29, 2024

Murderlon left a comment

Murderlon commented Dec 2, 2024

dschmidt commented Dec 2, 2024

Murderlon commented Dec 2, 2024

Murderlon commented Dec 2, 2024 •

edited

Loading

dschmidt commented Dec 2, 2024

Murderlon commented Dec 5, 2024

mifi left a comment

mifi Dec 6, 2024

mifi Dec 6, 2024

mifi Dec 6, 2024

dschmidt Dec 6, 2024

mifi Dec 6, 2024

dschmidt Dec 6, 2024

Murderlon Dec 6, 2024

mifi Dec 7, 2024

dschmidt commented Dec 6, 2024

Murderlon commented Dec 6, 2024

mifi commented Dec 7, 2024

dschmidt commented Dec 7, 2024

		requestPath, // TODO FIXME
		modifiedDate: item.lastmod, // TODO FIXME: convert 'Tue, 04 Jul 2023 13:09:47 GMT' to ISO 8601

	// can be implemented as regular require as soon as Node 20.17 or 22 is required
	// todo implement as regular require as soon as Node 20.17 or 22 is required

feat(webdav): initial implementation for a WebDAV simple auth provider #5528

Are you sure you want to change the base?

feat(webdav): initial implementation for a WebDAV simple auth provider #5528

Conversation

dschmidt commented Nov 28, 2024

dschmidt commented Nov 28, 2024

dschmidt commented Nov 29, 2024

Murderlon left a comment

Choose a reason for hiding this comment

Murderlon commented Dec 2, 2024

dschmidt commented Dec 2, 2024

Murderlon commented Dec 2, 2024

Murderlon commented Dec 2, 2024 • edited Loading

dschmidt commented Dec 2, 2024

Murderlon commented Dec 5, 2024

mifi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dschmidt commented Dec 6, 2024

Murderlon commented Dec 6, 2024

mifi commented Dec 7, 2024

dschmidt commented Dec 7, 2024

Murderlon commented Dec 2, 2024 •

edited

Loading