Skip to content

Commit

Permalink
Switch back to using cosignature (#241)
Browse files Browse the repository at this point in the history
This will reinstate timestamps in the witness signatures. This was dropped in #233 as a temporary measure to facilitate a transition between timestamp endianness. Any sigs that aren't verified are dropped, and thus the currently deployed distributors will drop the cosignature signatures.

If we want to support keeping both witness signatures around, we'll have to do some more engineering to have multiple verifiers per witness. We would also need to look at the merging code to ensure we only merge similar signatures. It seems easier to just drop the non-timestamped sigs on entry.
  • Loading branch information
mhutchinson authored Oct 23, 2024
1 parent ee842b6 commit 4a9a95b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ func ParseWitnessesConfig(y []byte) (map[string]note.Verifier, error) {
}
ws := make(map[string]note.Verifier)
for _, w := range witCfg.Witnesses {
// TODO(mhutchinson): Upgrade this to f_note.NewVerifierForCosignatureV1
wSigV, err := note.NewVerifier(w)
wSigV, err := f_note.NewVerifierForCosignatureV1(w)
if err != nil {
return nil, fmt.Errorf("invalid witness public key: %v", err)
}
Expand Down

0 comments on commit 4a9a95b

Please sign in to comment.