Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify content encoding on text/plain responses #217

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

aditsachde
Copy link
Contributor

Without the content encoding type specified, the character renders as — in Chrome.

https://api.transparency.dev/distributor/v0/logs/2371c7aa76ca0d588c7f21317b789071bb63593bd2c3d7b02ca5842f03680fda/checkpoint.14
image

Copy link

google-cla bot commented Sep 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4a9a95b). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage        ?   30.94%           
=======================================
  Files           ?        8           
  Lines           ?      656           
  Branches        ?        0           
=======================================
  Hits            ?      203           
  Misses          ?      424           
  Partials        ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlCutter AlCutter merged commit e399c09 into transparency-dev:main Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants